Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 555193002: Fix src_path now that deploy_aar has moved directories. (Closed)

Created:
6 years, 3 months ago by Jacob
Modified:
6 years, 3 months ago
Reviewers:
blois
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix src_path now that deploy_aar has moved directories. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=40053

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/dartium/deploy_aar.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
Jacob
6 years, 3 months ago (2014-09-09 17:26:38 UTC) #2
blois
lgtm https://codereview.chromium.org/555193002/diff/1/tools/dartium/deploy_aar.py File tools/dartium/deploy_aar.py (right): https://codereview.chromium.org/555193002/diff/1/tools/dartium/deploy_aar.py#newcode20 tools/dartium/deploy_aar.py:20: SRC_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "..", "..") line length
6 years, 3 months ago (2014-09-09 18:18:50 UTC) #3
Jacob
6 years, 3 months ago (2014-09-09 20:56:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 40053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698