Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 555123002: Filter abstract classes when computing candidate classes for custom elements. (Closed)

Created:
6 years, 3 months ago by herhut
Modified:
6 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Filter abstract classes when computing candidate classes for custom elements. BUG= http://dartbug.com/20845 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=40027

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/custom/document_register_basic_test.dart View 2 chunks +13 lines, -6 lines 2 comments Download
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
herhut
6 years, 3 months ago (2014-09-09 12:27:07 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/555123002/diff/20001/tests/html/custom/document_register_basic_test.dart File tests/html/custom/document_register_basic_test.dart (right): https://codereview.chromium.org/555123002/diff/20001/tests/html/custom/document_register_basic_test.dart#newcode64 tests/html/custom/document_register_basic_test.dart:64: expect(() => document.registerElement('x-bad-c', BadC), throws); You could make ...
6 years, 3 months ago (2014-09-09 13:02:22 UTC) #3
herhut
Committed patchset #1 (id:20001) manually as 40027 (presubmit successful).
6 years, 3 months ago (2014-09-09 13:31:48 UTC) #4
herhut
6 years, 3 months ago (2014-09-09 13:33:27 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/555123002/diff/20001/tests/html/custom/docume...
File tests/html/custom/document_register_basic_test.dart (right):

https://codereview.chromium.org/555123002/diff/20001/tests/html/custom/docume...
tests/html/custom/document_register_basic_test.dart:64: expect(() =>
document.registerElement('x-bad-c', BadC), throws);
On 2014/09/09 13:02:22, karlklose wrote:
> You could make this a multitest with label OK and add a comment to the status
> file to remove the label when fixing the bug.

Just for the record: It seems this is not supported.

Powered by Google App Engine
This is Rietveld 408576698