Issue 554783003: Add the ability for a PackageProvider to declare static packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554783003: Add the ability for a PackageProvider to declare static packages. (Closed)

Created:
6 years, 3 months ago by nweiz

Modified:
6 years, 3 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add the ability for a PackageProvider to declare static packages. Once pub gets rid of RewriteTransformer, this will allow it to avoid passing in assets to Barback unnecessarily. R=rnystrom@google.com BUG=20859 Committed: https://code.google.com/p/dart/source/detail?r=40118

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -26 lines)			Patch
M	pkg/barback/CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/asset_cascade.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/barback/lib/src/graph/package_graph.dart	View	3 chunks	+24 lines, -4 lines	0 comments	Download
A	pkg/barback/lib/src/graph/static_asset_cascade.dart	View	1 chunk	+81 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/package_provider.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1 chunk	+1 line, -6 lines	0 comments	Download
A	pkg/barback/test/static_provider_test.dart	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	pkg/barback/test/utils.dart	View	4 chunks	+21 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Bob Nystrom

LGTM! Have you started integrating this into pub yet? Any idea what kind of perf ...

6 years, 3 months ago (2014-09-10 18:18:54 UTC) #2

nweiz

6 years, 3 months ago (2014-09-10 21:13:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40118 (presubmit successful).