Issue 554273002: Add verbose option to poi.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554273002: Add verbose option to poi.dart. (Closed)

Created:
6 years, 3 months ago by ahe

Modified:
6 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, kasperl, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add verbose option to poi.dart. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=40033

Patch Set 1 : #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -13 lines)			Patch
	M	dart/site/try/poi/poi.dart	View		7 chunks	+36 lines, -13 lines	2 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

lgtm https://codereview.chromium.org/554273002/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/554273002/diff/20001/dart/site/try/poi/poi.dart#newcode92 dart/site/try/poi/poi.dart:92: /// really need. Nice comment :)

6 years, 3 months ago (2014-09-09 13:49:13 UTC) #4

ahe

Thanks, Johnni! :-) https://codereview.chromium.org/554273002/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/554273002/diff/20001/dart/site/try/poi/poi.dart#newcode92 dart/site/try/poi/poi.dart:92: /// really need. On 2014/09/09 13:49:13, ...

6 years, 3 months ago (2014-09-09 14:35:13 UTC) #5

ahe

6 years, 3 months ago (2014-09-09 14:41:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as 40033 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages