Issue 554143003: Integrate the EXTRACT_METHOD refactoring into Editor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554143003: Integrate the EXTRACT_METHOD refactoring into Editor. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Integrate the EXTRACT_METHOD refactoring into Editor. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40034

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+349 lines, -1848 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ExtractMethodAction.java	View	1 chunk	+0 lines, -112 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ExtractMethodAction_NEW.java	View	3 chunks	+9 lines, -9 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/ExtractMethodAction_OLD.java	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup_NEW.java	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/actions/RefactorActionGroup_OLD.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ChangeParametersControl.java	View	1 chunk	+0 lines, -789 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ChangeParametersControl_NEW.java	View	25 chunks	+119 lines, -107 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ChangeParametersControl_OLD.java	View	6 chunks	+9 lines, -9 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodInputPage.java	View	1 chunk	+0 lines, -349 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodInputPage_NEW.java	View	15 chunks	+23 lines, -23 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodInputPage_OLD.java	View	4 chunks	+5 lines, -5 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodWizard.java	View	1 chunk	+0 lines, -49 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodWizard_NEW.java	View	2 chunks	+4 lines, -18 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ExtractMethodWizard_OLD.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/IParameterListChangeListener.java	View	1 chunk	+0 lines, -59 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/IParameterListChangeListener_NEW.java	View	2 chunks	+8 lines, -8 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/IParameterListChangeListener_OLD.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
D	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ParameterEditDialog.java	View	1 chunk	+0 lines, -257 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ParameterEditDialog_NEW.java	View	8 chunks	+28 lines, -28 lines	0 comments	Download
A +	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ParameterEditDialog_OLD.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/refactoring/ServerExtractMethodRefactoring.java	View	1 chunk	+119 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 3 months ago (2014-09-09 14:57:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40034 (presubmit successful).

Expand Messages | Collapse Messages