Issue 554033005: Allows allocation of LR on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554033005: Allows allocation of LR on ARM. (Closed)

Created:
6 years, 3 months ago by zra

Modified:
6 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allows allocation of LR on ARM. It was already being saved and restored as necessary, so I just had to move the bound in constants_arm.h. Looks like there was also a bad bug in LoadWordFromPoolOffset, but it was never triggered because rd was always LR. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40055

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	runtime/vm/assembler_arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/constants_arm.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

6 years, 3 months ago (2014-09-09 21:04:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40055 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages