Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 553823002: Revert change r37732. Remove copies of scripts from old location. (Closed)

Created:
6 years, 3 months ago by Bill Hesse
Modified:
6 years, 3 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert change r37732, using hashes rather than revision numbers for archived chromium builds. Remove copies of scripts from old location. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=39950

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -263 lines) Patch
M dart/tools/bots/get_chromium_build.py View 1 3 chunks +7 lines, -5 lines 0 comments Download
D dart/tools/dartium/fetch_reference_build.py View 1 chunk +0 lines, -49 lines 0 comments Download
D dart/tools/dartium/get_chromium_build.py View 1 chunk +0 lines, -171 lines 0 comments Download
D dart/tools/dartium/set_reference_build_revision.py View 1 chunk +0 lines, -29 lines 0 comments Download
M deps/dartium.deps/DEPS View 1 1 chunk +1 line, -5 lines 0 comments Download
M deps/multivm.deps/DEPS View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Bill Hesse
The current versions of the scripts are in tools/bots. These ones in tools/dartium are outdated ...
6 years, 3 months ago (2014-09-08 08:21:27 UTC) #2
ricow1
https://codereview.chromium.org/553823002/diff/1/deps/multivm.deps/DEPS File deps/multivm.deps/DEPS (right): https://codereview.chromium.org/553823002/diff/1/deps/multivm.deps/DEPS#newcode15 deps/multivm.deps/DEPS:15: '{"Windows": "293094", ' + why?
6 years, 3 months ago (2014-09-08 08:22:23 UTC) #3
Bill Hesse
Changed the code back to the way it was before using platform-specific hashes. Now the ...
6 years, 3 months ago (2014-09-08 09:41:28 UTC) #4
ricow1
lgtm
6 years, 3 months ago (2014-09-08 10:33:59 UTC) #5
Bill Hesse
6 years, 3 months ago (2014-09-08 10:34:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r39950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698