Issue 55363005: update shadow dom pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55363005: update shadow dom pkg (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly

Modified:
7 years, 1 month ago

Reviewers:
terry, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

update shadow dom pkg ShadowDOM is at revision 31c0d9699b5b41bdb1c36e26d0956574dac684e3 platform is at revision dad88031041c887cc0de2fd6164bc5c4ca3019ae R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29858

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+290 lines, -679 lines)			Patch
M	pkg/shadow_dom/lib/shadow_dom.debug.js	View	1	35 chunks	+278 lines, -100 lines	0 comments	Download
M	pkg/shadow_dom/lib/shadow_dom.min.js	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
D	pkg/shadow_dom/lib/src/platform/ShadowCSS.js	View		1 chunk	+0 lines, -574 lines	0 comments	Download
M	pkg/shadow_dom/tool/build.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/shadow_dom/tool/build.sh	View		3 chunks	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/55363005/diff/30001/pkg/shadow_dom/tool/build.sh File pkg/shadow_dom/tool/build.sh (right): https://codereview.chromium.org/55363005/diff/30001/pkg/shadow_dom/tool/build.sh#newcode44 pkg/shadow_dom/tool/build.sh:44: echo "*** Revision hash to use in commit ...

7 years, 1 month ago (2013-11-04 22:49:15 UTC) #2

Jennifer Messerly

Committed patchset #2 manually as r29858 (presubmit successful).

7 years, 1 month ago (2013-11-04 22:50:15 UTC) #3

Message was sent while issue was closed.

lgtm

Thanks!

Expand Messages | Collapse Messages