Implement "analysis.reanalyze" in analysis server.

Implement "analysis.reanalyze" in analysis server.

This is accomplished by instructing the context manager to remove all
contexts and recreate them from scratch.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40106

[Paul Berry, 2014-09-09 22:29:59]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-09-10 01:55:55]

LGTM

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:113: for (Folder newFolder in
contextFolders) {
With this implementation we trust that we have a valid set of folders with
created contexts, and want to fix contexts. This set may be, or may be not
valid.

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:116:
folder.isOrContains(newFolder.path);
Will folder.contains(newFolder.path) replace both conditions?

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis/reanalyze_test.dart (right):

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis/reanalyze_test.dart:12: import
'package:analysis_server/src/constants.dart';
Sort imports.

[Paul Berry, 2014-09-10 18:26:12]

PTAL

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:113: for (Folder newFolder in
contextFolders) {
On 2014/09/10 01:55:54, scheglov wrote:
> With this implementation we trust that we have a valid set of folders with
> created contexts, and want to fix contexts. This set may be, or may be not
> valid.

Fair enough.  I've reworked things so that we accomplish refresh() by destroying
the old contexts and then calling setRoots() with the previously supplied
include/exclude lists.  This should ensure that we get correct behavior no
matter what has happened to the filesystem.

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/context_manager.dart:116:
folder.isOrContains(newFolder.path);
On 2014/09/10 01:55:54, scheglov wrote:
> Will folder.contains(newFolder.path) replace both conditions?

Acknowledged.  This code is gone now.

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis/reanalyze_test.dart (right):

https://codereview.chromium.org/553193002/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis/reanalyze_test.dart:12: import
'package:analysis_server/src/constants.dart';
On 2014/09/10 01:55:54, scheglov wrote:
> Sort imports.

Done.

[scheglov, 2014-09-10 18:37:50]

LGTM

https://codereview.chromium.org/553193002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/553193002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/context_manager.dart:61: List<String> includedPaths
= <String>[];
I'd put "included" before "exclude", as we do in setRoots(), and we don't sort
(automatically) fields by their names. But it's up to you.

[Paul Berry, 2014-09-10 19:20:16]

Committed patchset #2 manually as 40106 (presubmit successful).