Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552973003: Fix Uri.replace adding an empty authority by mistake. (Closed)

Created:
6 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 3 months ago
Reviewers:
Søren Gjesse, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix Uri.replace adding an empty authority by mistake. BUG= http://dartbug.com/20814 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=40020

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M sdk/lib/core/uri.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/uri_test.dart View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-09-09 09:27:53 UTC) #2
Søren Gjesse
lgtm
6 years, 3 months ago (2014-09-09 10:14:34 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 manually as r40020 (presubmit successful).
6 years, 3 months ago (2014-09-09 10:50:47 UTC) #4
kasperl
https://codereview.chromium.org/552973003/diff/1/tests/corelib/uri_test.dart File tests/corelib/uri_test.dart (right): https://codereview.chromium.org/552973003/diff/1/tests/corelib/uri_test.dart#newcode430 tests/corelib/uri_test.dart:430: var uri = Uri.parse("/no-authorty/"); Is the typo intentional?
6 years, 3 months ago (2014-09-09 11:07:05 UTC) #6
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-09-09 11:08:49 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/552973003/diff/1/tests/corelib/uri_test.dart
File tests/corelib/uri_test.dart (right):

https://codereview.chromium.org/552973003/diff/1/tests/corelib/uri_test.dart#...
tests/corelib/uri_test.dart:430: var uri = Uri.parse("/no-authorty/");
Nope, well spotted. 
It is, however, also completely inconsequential.
I'll fix it in some other CL eventually :)

Powered by Google App Engine
This is Rietveld 408576698