Issue 552443003: Add package-root option to the testing scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552443003: Add package-root option to the testing scripts (Closed)

Created:
6 years, 3 months ago by ricow1

Modified:
6 years, 3 months ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add package-root option to the testing scripts R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39971

Patch Set 1 #

Total comments: 4

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
M	tools/test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/testing/dart/http_server.dart	View	7 chunks	+16 lines, -5 lines	3 comments	Download
M	tools/testing/dart/test_options.dart	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	tools/testing/dart/test_suite.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/552443003/diff/1/tools/testing/dart/http_server.dart File tools/testing/dart/http_server.dart (right): https://codereview.chromium.org/552443003/diff/1/tools/testing/dart/http_server.dart#newcode60 tools/testing/dart/http_server.dart:60: /// passed in package root passed-in package root. ...

6 years, 3 months ago (2014-09-08 15:31:21 UTC) #2

ricow1

6 years, 3 months ago (2014-09-08 15:44:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r39971 (presubmit successful).

Expand Messages | Collapse Messages