Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 552253002: Adapt TypeMask tests to new TypeMask interface. (Closed)

Created:
6 years, 3 months ago by herhut
Modified:
6 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adapt TypeMask tests to new TypeMask interface. BUG= TBR=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=40021

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M tests/compiler/dart2js/cpa_inference_test.dart View 5 chunks +19 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +13 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +6 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
herhut
Committed patchset #1 (id:1) manually as 40021 (presubmit successful).
6 years, 3 months ago (2014-09-09 10:55:06 UTC) #1
karlklose
https://codereview.chromium.org/552253002/diff/1/tests/compiler/dart2js/union_type_test.dart File tests/compiler/dart2js/union_type_test.dart (right): https://codereview.chromium.org/552253002/diff/1/tests/compiler/dart2js/union_type_test.dart#newcode14 tests/compiler/dart2js/union_type_test.dart:14: MockCompiler compiler = new MockCompiler.internal(analyzeOnly: true); Why this change?
6 years, 3 months ago (2014-09-09 10:59:15 UTC) #2
herhut
https://codereview.chromium.org/552253002/diff/1/tests/compiler/dart2js/union_type_test.dart File tests/compiler/dart2js/union_type_test.dart (right): https://codereview.chromium.org/552253002/diff/1/tests/compiler/dart2js/union_type_test.dart#newcode14 tests/compiler/dart2js/union_type_test.dart:14: MockCompiler compiler = new MockCompiler.internal(analyzeOnly: true); On 2014/09/09 10:59:15, ...
6 years, 3 months ago (2014-09-09 11:03:58 UTC) #3
karlklose
6 years, 3 months ago (2014-09-09 12:13:37 UTC) #4
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698