Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 551933003: rename completion class (Closed)

Created:
6 years, 3 months ago by danrubel
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -359 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 3 chunks +4 lines, -4 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/imported_type_computer.dart View 1 chunk +0 lines, -148 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/imported_computer_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/services/completion/imported_type_computer_test.dart View 1 chunk +0 lines, -201 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 3 months ago (2014-09-08 18:15:57 UTC) #2
Paul Berry
lgtm
6 years, 3 months ago (2014-09-08 18:31:53 UTC) #3
danrubel
6 years, 3 months ago (2014-09-08 18:38:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698