Issue 55173002: Fix a few warnings and update status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 55173002: Fix a few warnings and update status file. (Closed)

Created:
7 years, 1 month ago by floitsch

Modified:
7 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a few warnings and update status file. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=29759

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	sdk/lib/async/future_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/errors.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/analyzer/analyze_library.status	View	1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/55173002/diff/1/tests/lib/analyzer/analyze_library.status File tests/lib/analyzer/analyze_library.status (right): https://codereview.chromium.org/55173002/diff/1/tests/lib/analyzer/analyze_library.status#newcode6 tests/lib/analyzer/analyze_library.status:6: lib/core/bool: CompileTimeError, OK # Issue 14684. Only redirecting ...

7 years, 1 month ago (2013-11-01 09:39:00 UTC) #2

floitsch

7 years, 1 month ago (2013-11-01 17:32:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29759 (presubmit successful).

Expand Messages | Collapse Messages