Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 551713003: Fix handling default parameters (Closed)

Created:
6 years, 3 months ago by terry
Modified:
6 years, 3 months ago
Reviewers:
vsm, Leaf
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Reviewers=vsm,leafp Fixed emitting problems with default/optional. R=leafp@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=40054

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -15 lines) Patch
M tools/dom/idl/dart/dart.idl View 3 chunks +4 lines, -5 lines 2 comments Download
M tools/dom/scripts/databasebuilder.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +7 lines, -3 lines 0 comments Download
M tools/dom/scripts/idlnode.py View 1 4 chunks +18 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
terry
[Default=xxxxx] was not handled properly. Latest IDL parser for argument defaults uses this syntax DOMString ...
6 years, 3 months ago (2014-09-09 20:37:15 UTC) #2
Leaf
lgtm with one comment. https://codereview.chromium.org/551713003/diff/20001/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/551713003/diff/20001/tools/dom/idl/dart/dart.idl#newcode257 tools/dom/idl/dart/dart.idl:257: interface VoidCallback { This interface ...
6 years, 3 months ago (2014-09-09 20:47:29 UTC) #3
vsm
lgtm
6 years, 3 months ago (2014-09-09 20:48:02 UTC) #4
terry
https://codereview.chromium.org/551713003/diff/20001/tools/dom/idl/dart/dart.idl File tools/dom/idl/dart/dart.idl (right): https://codereview.chromium.org/551713003/diff/20001/tools/dom/idl/dart/dart.idl#newcode257 tools/dom/idl/dart/dart.idl:257: interface VoidCallback { Good idea I'll look at that ...
6 years, 3 months ago (2014-09-09 20:58:35 UTC) #5
terry
6 years, 3 months ago (2014-09-09 20:59:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698