Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 551383002: Add --enable-dart-mind option to poi.dart. (Closed)

Created:
6 years, 3 months ago by ahe
Modified:
6 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Add --enable-dart-mind option to poi.dart. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=40035

Patch Set 1 #

Patch Set 2 : Updated documentation. #

Total comments: 2

Patch Set 3 : Update test to use new variable name. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M dart/site/try/poi/poi.dart View 1 5 chunks +12 lines, -6 lines 0 comments Download
M dart/tests/try/poi/poi_test.dart View 1 2 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (1 generated)
ahe
6 years, 3 months ago (2014-09-09 12:11:39 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/551383002/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/551383002/diff/20001/dart/site/try/poi/poi.dart#newcode294 dart/site/try/poi/poi.dart:294: } You're missing a `sw.reset()` if we don't ...
6 years, 3 months ago (2014-09-09 13:52:21 UTC) #3
ahe
Thanks, Johnni. Let me know if I misunderstood your comment. https://codereview.chromium.org/551383002/diff/20001/dart/site/try/poi/poi.dart File dart/site/try/poi/poi.dart (right): https://codereview.chromium.org/551383002/diff/20001/dart/site/try/poi/poi.dart#newcode294 ...
6 years, 3 months ago (2014-09-09 14:49:18 UTC) #4
ahe
https://codereview.chromium.org/551383002/diff/40001/dart/tests/try/poi/poi_test.dart File dart/tests/try/poi/poi_test.dart (right): https://codereview.chromium.org/551383002/diff/40001/dart/tests/try/poi/poi_test.dart#newcode38 dart/tests/try/poi/poi_test.dart:38: poi.isDartMindEnabled = false; Trivial update of this test.
6 years, 3 months ago (2014-09-09 15:01:02 UTC) #5
ahe
6 years, 3 months ago (2014-09-09 15:01:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 40035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698