Fix for List<Future> is not assignable to List.

Fix for List<Future> is not assignable to List.

Instead of pushing core.dart file, we should pre-index SDK.

R=danrubel@google.com, paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40038

[danrubel, 2014-09-09 02:19:34]

lgtm

[Paul Berry, 2014-09-09 15:28:25]

lgtm

I assume this is a fix for the issue we discussed yesterday, where some tests
would fail when run via test_all.dart but not when run individually?  If so, it
would be nice to have a sentence or two in the commit message explaining what's
going on here (i.e. what global state was getting corrupted prior to the change,
and how the change avoids it).  As written it's hard to imagine what this change
has to do with List<Future> not assignable to List.

[scheglov, 2014-09-09 16:24:10]

https://codereview.chromium.org/551103003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/completion/completion_test_util.dart
(left):

https://codereview.chromium.org/551103003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/completion/completion_test_util.dart:206:
addResolvedUnit(MockSdk.LIB_CORE.path, MockSdk.LIB_CORE.content);
This line violates the Spec by declaring class Object outside of the SDK.

So, some classes end up using Object from the SDK, and some - from the file
system.

[scheglov, 2014-09-09 16:24:27]

Committed patchset #1 (id:1) manually as 40038 (presubmit successful).