Add a --mode flag to pub run and pub global run.

Add a --mode flag to pub run and pub global run.

pub run now defaults to --mode=debug for local executables.

R=rnystrom@google.com
BUG=20898
Committed: https://code.google.com/p/dart/source/detail?r=40384

[Bob Nystrom, 2014-09-12 21:21:20]

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/run.dart:28: '(defaults to "release" for
dependencies, "debug" for entrypoint)');
Long line.

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/executable.dart:48: // Dependencies are only
snapshotted in release mode, since that's the
Why not snapshot other modes too, on-demand?

[nweiz, 2014-09-16 00:21:42]

Code review changes

[nweiz, 2014-09-16 00:22:15]

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/command/run.dart (right):

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/command/run.dart:28: '(defaults to "release" for
dependencies, "debug" for entrypoint)');
On 2014/09/12 21:21:19, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/executable.dart:48: // Dependencies are only
snapshotted in release mode, since that's the
On 2014/09/12 21:21:19, Bob Nystrom wrote:
> Why not snapshot other modes too, on-demand?

Snapshotting takes time in and of itself, and I don't expect users to be running
external dependencies in other modes often enough for it to really make sense to
snapshot them separately. It's also hard to know when to invalidate those
snapshots—if I run polymer:new_element in debug mode once, I don't want it
sitting on my computer forevermore.

[Bob Nystrom, 2014-09-16 19:51:11]

lgtm

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/executable.dart (right):

https://codereview.chromium.org/550643003/diff/40001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/executable.dart:48: // Dependencies are only
snapshotted in release mode, since that's the
On 2014/09/16 00:22:15, nweiz wrote:
> On 2014/09/12 21:21:19, Bob Nystrom wrote:
> > Why not snapshot other modes too, on-demand?
> 
> Snapshotting takes time in and of itself, 

It doesn't take much more time beyond standing up barback and running all the
transformers, and if you don't snapshot, you have to do that process every time.

> and I don't expect users to be running
> external dependencies in other modes often enough for it to really make sense
to
> snapshot them separately.

I guess so. We should keep an eye on this though and if it seems like users do
this often optimize for it.

> It's also hard to know when to invalidate those
> snapshots—if I run polymer:new_element in debug mode once, I don't want it
> sitting on my computer forevermore.

Well, there's only so many modes, and it's scoped to the user's .pub directory
so it's probably not the end of the world, but sure.

[nweiz, 2014-09-17 18:33:03]

Committed patchset #4 (id:60001) manually as 40384 (presubmit successful).