Make test of malformed types a dynamic type error.

Make test of malformed types a dynamic type error.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29897

[Johnni Winther, 2013-11-04 13:46:00]

PTAL

[karlklose, 2013-11-05 09:48:14]

LGTM.

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:123: value
= null;
make sure there is a test for this.

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_helper.dart:1942: malformedTypeCheck(value, message) {
This method does not actually do a type check (same with the method above). Can
you think of a better name?

https://codereview.chromium.org/54983007/diff/90001/tests/language/div_with_p...
File tests/language/div_with_power_of_two2_test.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/div_with_p...
tests/language/div_with_power_of_two2_test.dart:103: || e is UnsupportedError);
Why this change?

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
File tests/language/malformed2_lib.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_lib.dart:41: } on List<Unresolved> catch (e) {
Perhaps document in a comment on this method or malformed2_test that this method
uses List<String> and null as example types.

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
File tests/language/malformed2_test.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_test.dart:22: void fail(String message) {
Add a new line here and after the method.

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_test.dart:37: if (expectTypeError) {
If you test expectTypeError directly in line 40 and 42 you can merge the two
try-blocks.

[Johnni Winther, 2013-11-05 10:58:41]

PTAL at the last changes.

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart
(right):

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:123: value
= null;
On 2013/11/05 09:48:14, karlklose wrote:
> make sure there is a test for this.

Done.

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_helper.dart (right):

https://codereview.chromium.org/54983007/diff/90001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_helper.dart:1942: malformedTypeCheck(value, message) {
On 2013/11/05 09:48:14, karlklose wrote:
> This method does not actually do a type check (same with the method above).
Can
> you think of a better name?

Changed to 'checkMalformedType'.

https://codereview.chromium.org/54983007/diff/90001/tests/language/div_with_p...
File tests/language/div_with_power_of_two2_test.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/div_with_p...
tests/language/div_with_power_of_two2_test.dart:103: || e is UnsupportedError);
On 2013/11/05 09:48:14, karlklose wrote:
> Why this change?

RuntimeError doesn't exist. UnsupportedError is what is actually thrown.

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
File tests/language/malformed2_lib.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_lib.dart:41: } on List<Unresolved> catch (e) {
On 2013/11/05 09:48:14, karlklose wrote:
> Perhaps document in a comment on this method or malformed2_test that this
method
> uses List<String> and null as example types.

Done.

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
File tests/language/malformed2_test.dart (right):

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_test.dart:22: void fail(String message) {
On 2013/11/05 09:48:14, karlklose wrote:
> Add a new line here and after the method.

Done.

https://codereview.chromium.org/54983007/diff/90001/tests/language/malformed2...
tests/language/malformed2_test.dart:37: if (expectTypeError) {
On 2013/11/05 09:48:14, karlklose wrote:
> If you test expectTypeError directly in line 40 and 42 you can merge the two
> try-blocks.

Done.

[karlklose, 2013-11-05 11:33:34]

LGTM.

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
File tests/language/malformed2_lib.dart (right):

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
tests/language/malformed2_lib.dart:7: /// [o] is either `null` or `new
List<String>()`.
We could even assert it so it explodes if someone tries to add to the test.

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
File tests/language/malformed2_test.dart (right):

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
tests/language/malformed2_test.dart:52: const Unresolved c1 = 0; /// 01: static
type warning, compile-time error
Do you really need to write 'static type warning' here? I though compile-time
error subsumes it.

[Johnni Winther, 2013-11-05 12:18:05]

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
File tests/language/malformed2_lib.dart (right):

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
tests/language/malformed2_lib.dart:7: /// [o] is either `null` or `new
List<String>()`.
On 2013/11/05 11:33:35, karlklose wrote:
> We could even assert it so it explodes if someone tries to add to the test.

Done.

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
File tests/language/malformed2_test.dart (right):

https://codereview.chromium.org/54983007/diff/180001/tests/language/malformed...
tests/language/malformed2_test.dart:52: const Unresolved c1 = 0; /// 01: static
type warning, compile-time error
On 2013/11/05 11:33:35, karlklose wrote:
> Do you really need to write 'static type warning' here? I though compile-time
> error subsumes it. 

For the analyzer!

[Johnni Winther, 2013-11-05 12:29:53]

Committed patchset #6 manually as r29897 (presubmit successful).