Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 549623003: Make compiler imports relative in async-compiled code. (Closed)

Created:
6 years, 3 months ago by Bob Nystrom
Modified:
6 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make compiler imports relative in async-compiled code. Committed: https://code.google.com/p/dart/source/detail?r=40042

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M sdk/lib/_internal/pub/bin/async_compile.dart View 1 chunk +2 lines, -1 line 1 comment Download
M sdk/lib/_internal/pub_generated/bin/async_compile.dart View 1 chunk +2 lines, -1 line 1 comment Download
M sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/dart.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bob Nystrom
TBR.
6 years, 3 months ago (2014-09-09 17:09:35 UTC) #2
Bob Nystrom
Committed patchset #1 (id:1) manually as 40042 (presubmit successful).
6 years, 3 months ago (2014-09-09 17:09:58 UTC) #3
nweiz
https://codereview.chromium.org/549623003/diff/1/sdk/lib/_internal/pub/bin/async_compile.dart File sdk/lib/_internal/pub/bin/async_compile.dart (right): https://codereview.chromium.org/549623003/diff/1/sdk/lib/_internal/pub/bin/async_compile.dart#newcode179 sdk/lib/_internal/pub/bin/async_compile.dart:179: from: p.dirname(p.toUri(destPath).toString())); This should be p.url.dirname if it's working ...
6 years, 3 months ago (2014-09-09 19:21:31 UTC) #4
nweiz
6 years, 3 months ago (2014-09-09 19:32:17 UTC) #5
Message was sent while issue was closed.
Just saw your other CL. lgtm

Powered by Google App Engine
This is Rietveld 408576698