Issue 54923006: Revert "Fixing the BeforeUnloadEvent"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54923006: Revert "Fixing the BeforeUnloadEvent" (Closed)

Created:
7 years, 1 month ago by blois

Modified:
7 years, 1 month ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Fixing the BeforeUnloadEvent" Causing problems with build on Dartium: class _CustomEventStreamImpl<T extends Event> extends Stream<T> ^ 'file:///mnt/data/b/build/slave/dartium-lucid32-full-be/build/src/dart/tools/dom/src/EventStreamProvider.dart': Error: line 334 pos 41: type '_CustomEventStreamImpl<KeyEvent>' has an out of bound type argument class _CustomKeyEventStreamImpl extends _CustomEventStreamImpl<KeyEvent> TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=29754

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -51 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+23 lines, -12 lines	0 comments	Download
M	tools/dom/dom.json	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	3 chunks	+5 lines, -17 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	4 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 1 month ago (2013-11-01 16:37:45 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r29754 (presubmit successful).

Expand Messages | Collapse Messages