Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 54903009: Issue 14685. Don't analyzer parts. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Inform user that only libraries can be analyzed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -89 lines) Patch
M editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java View 1 2 chunks +21 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 2 chunks +16 lines, -1 line 0 comments Download
M tests/lib/analyzer/analyze_library.status View 2 chunks +1 line, -87 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 1 month ago (2013-11-01 22:15:59 UTC) #1
jwren
On 2013/11/01 22:15:59, scheglov wrote: LGTM
7 years, 1 month ago (2013-11-01 22:24:50 UTC) #2
Brian Wilkerson
LGTM once the user is being notified of the incorrect usage of the tool. https://codereview.chromium.org/54903009/diff/1/editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java ...
7 years, 1 month ago (2013-11-01 23:02:19 UTC) #3
scheglov
7 years, 1 month ago (2013-11-01 23:46:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698