ARM: for StrictCompare cache constant values in register instead of materializing it each time. Nex…

ARM: for StrictCompare cache constant values in register instead of materializing it each time. Next step: port it to other platform that have slower materialization of constants.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39929

[srdjan, 2014-09-05 20:40:37]

srdjan@google.com changed reviewers:
+ zra@google.com

[zra, 2014-09-05 20:52:15]

lgtm with suggestion

https://codereview.chromium.org/548633003/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/548633003/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_arm.cc:7122: if ((constant != NULL) &&
!left()->IsSingleUse()) {
Maybe add comment like: "Make sure we use a register if the constant has more
than one use. This is to avoid doing another immediate load."

[srdjan, 2014-09-05 20:58:29]

https://codereview.chromium.org/548633003/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/548633003/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_arm.cc:7122: if ((constant != NULL) &&
!left()->IsSingleUse()) {
On 2014/09/05 20:52:15, zra wrote:
> Maybe add comment like: "Make sure we use a register if the constant has more
> than one use. This is to avoid doing another immediate load."

Done.

[srdjan, 2014-09-05 20:58:49]

Committed patchset #3 (id:40001) manually as r39929 (presubmit successful).