Fix warnings in library-tests.

Fix warnings in library-tests.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29756

[Lasse Reichstein Nielsen, 2013-11-01 09:37:35]

lgtm

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_test.dart:21: CaptureEvents actualEvents = new
Events.capture(c.stream.asBroadcastStream());
Ah, due to using the subscription field.

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_transf...
File tests/lib/async/stream_transformer_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_transf...
tests/lib/async/stream_transformer_test.dart:24: Future cancel() {}
Change it to '=> null;', just to be sure.

It should be a warning to not return a value from a function with a non-void
return type. Even if we maybe haven't made it one yet.

https://codereview.chromium.org/54723007/diff/1/tests/lib/math/min_max_test.dart
File tests/lib/math/min_max_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/math/min_max_test.d...
tests/lib/math/min_max_test.dart:23: bool operator==(other) => other is Wrap &&
compareTo(other) == 0;
So this never worked?

[floitsch, 2013-11-01 16:57:25]

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_test.dart:21: CaptureEvents actualEvents = new
Events.capture(c.stream.asBroadcastStream());
On 2013/11/01 09:37:36, Lasse Reichstein Nielsen wrote:
> Ah, due to using the subscription field.
> 

yes.

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_transf...
File tests/lib/async/stream_transformer_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/async/stream_transf...
tests/lib/async/stream_transformer_test.dart:24: Future cancel() {}
On 2013/11/01 09:37:36, Lasse Reichstein Nielsen wrote:
> Change it to '=> null;', just to be sure.
> 
> It should be a warning to not return a value from a function with a non-void
> return type. Even if we maybe haven't made it one yet.

Done.

https://codereview.chromium.org/54723007/diff/1/tests/lib/math/min_max_test.dart
File tests/lib/math/min_max_test.dart (right):

https://codereview.chromium.org/54723007/diff/1/tests/lib/math/min_max_test.d...
tests/lib/math/min_max_test.dart:23: bool operator==(other) => other is Wrap &&
compareTo(other) == 0;
On 2013/11/01 09:37:36, Lasse Reichstein Nielsen wrote:
> So this never worked?

It was testing that there was an error if the input was not a number. Since the
code worked it never invoked the operators and failed before.
If our code was broken we wouldn't have noticed, though.

[floitsch, 2013-11-01 17:01:23]

Committed patchset #2 manually as r29756 (presubmit successful).