Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 54623003: Change bool.fromEnvironment to recognize "true" and "false" and use default for rest. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ngeoffray
Visibility:
Public.

Description

Change bool.fromEnvironment to recognize "true" and "false" and use default for rest. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M runtime/lib/bool.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/core/bool.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M tests/corelib/bool_from_environment_test.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 14:02:48 UTC) #1
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 14:03:43 UTC) #2
Søren Gjesse
lgtm
7 years, 1 month ago (2013-10-31 14:03:53 UTC) #3
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 14:05:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r29672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698