Issue 54623002: Fix bug in our SSA optimizations: by giving an empty type to a box, we were assuming that anything …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54623002: Fix bug in our SSA optimizations: by giving an empty type to a box, we were assuming that anything … (Closed)

Created:
7 years, 1 month ago by ngeoffray

Modified:
7 years, 1 month ago

Reviewers:
lukas, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix bug in our SSA optimizations: by giving an empty type to a box, we were assuming that anything that comes out of it is greater than zero. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29666

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -6 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/range_analysis2_test.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

ngeoffray

7 years, 1 month ago (2013-10-31 12:40:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29666 (presubmit successful).