Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 54613002: Update metadata syntax test to check for non-existing constants and type literals (see issue 14647). (Closed)

Created:
7 years, 1 month ago by kasperl
Modified:
7 years, 1 month ago
Reviewers:
bakster, scheglov, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update metadata syntax test to check for non-existing constants and type literals (see issue 14647). R=bak@google.com, hausner@google.com, scheglov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/metadata_syntax_test.dart View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 1 month ago (2013-10-31 12:02:32 UTC) #1
bakster
LGTM. Fixing 14647 will eliminate broken use of annotations. //Lars
7 years, 1 month ago (2013-10-31 12:41:29 UTC) #2
kasperl
7 years, 1 month ago (2013-10-31 12:57:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698