Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 546053002: - Refactor the way X.fromEnvironment is implemented. (Closed)

Created:
6 years, 3 months ago by Ivan Posva
Modified:
6 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Refactor the way X.fromEnvironment is implemented. - Predefine 'dart.isVM' to be 'true'. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39986

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -56 lines) Patch
M runtime/lib/bool.cc View 1 chunk +8 lines, -18 lines 0 comments Download
M runtime/lib/integers.cc View 1 chunk +8 lines, -20 lines 0 comments Download
M runtime/lib/string.cc View 1 chunk +4 lines, -18 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 chunk +2 lines, -0 lines 2 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/corelib/bool_from_environment_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
6 years, 3 months ago (2014-09-05 20:26:30 UTC) #2
srdjan
lgtm https://codereview.chromium.org/546053002/diff/1/runtime/vm/dart_api_impl.h File runtime/vm/dart_api_impl.h (right): https://codereview.chromium.org/546053002/diff/1/runtime/vm/dart_api_impl.h#newcode271 runtime/vm/dart_api_impl.h:271: static RawString* CallEnvironmentCallback(Isolate*, const String& name); Isolate* isolate,
6 years, 3 months ago (2014-09-08 18:12:04 UTC) #3
Ivan Posva
Thanks! -Ivan https://codereview.chromium.org/546053002/diff/1/runtime/vm/dart_api_impl.h File runtime/vm/dart_api_impl.h (right): https://codereview.chromium.org/546053002/diff/1/runtime/vm/dart_api_impl.h#newcode271 runtime/vm/dart_api_impl.h:271: static RawString* CallEnvironmentCallback(Isolate*, const String& name); On ...
6 years, 3 months ago (2014-09-08 18:16:34 UTC) #4
Ivan Posva
6 years, 3 months ago (2014-09-08 18:23:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as r39986 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698