Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 545343002: Add a manual test for inspecting types that have a special VM implementation. (Closed)

Created:
6 years, 3 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a manual test for inspecting types that have a special VM implementation. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=39982

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -20 lines) Patch
A runtime/bin/vmservice/observatory/tests/ui/inspector.dart View 1 1 chunk +149 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/tests/ui/inspector.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/tests/ui/retainingPath.dart View 1 1 chunk +6 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
6 years, 3 months ago (2014-09-05 20:10:52 UTC) #2
turnidge
lgtm w/ two small comments https://codereview.chromium.org/545343002/diff/1/runtime/bin/vmservice/observatory/tests/ui/inspector.dart File runtime/bin/vmservice/observatory/tests/ui/inspector.dart (right): https://codereview.chromium.org/545343002/diff/1/runtime/bin/vmservice/observatory/tests/ui/inspector.dart#newcode1 runtime/bin/vmservice/observatory/tests/ui/inspector.dart:1: library manual_inspector_test; Do we ...
6 years, 3 months ago (2014-09-08 16:32:59 UTC) #3
rmacnak
https://codereview.chromium.org/545343002/diff/1/runtime/bin/vmservice/observatory/tests/ui/inspector.dart File runtime/bin/vmservice/observatory/tests/ui/inspector.dart (right): https://codereview.chromium.org/545343002/diff/1/runtime/bin/vmservice/observatory/tests/ui/inspector.dart#newcode1 runtime/bin/vmservice/observatory/tests/ui/inspector.dart:1: library manual_inspector_test; On 2014/09/08 16:32:59, turnidge wrote: > Do ...
6 years, 3 months ago (2014-09-08 17:25:57 UTC) #4
rmacnak
6 years, 3 months ago (2014-09-08 17:38:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39982 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698