Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 54493002: Remove implicit_setter_test. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove implicit_setter_test. Implicit throwing setters for final fields were reverted from the spec. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -73 lines) Patch
D tests/language/implicit_setter_test.dart View 1 chunk +0 lines, -63 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 10:20:44 UTC) #1
Florian Schneider
LGTM.
7 years, 1 month ago (2013-10-31 10:21:26 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 10:22:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698