Issue 544753002: Address static warnings in the service library and tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 544753002: Address static warnings in the service library and tests. (Closed)

Created:
6 years, 3 months ago by rmacnak

Modified:
6 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Address static warnings in the service library and tests. BUG=http://dartbug.com/20805 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39882

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -20 lines)			Patch
M	runtime/bin/vmservice/observatory/lib/src/service/object.dart	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	runtime/bin/vmservice/observatory/test/contexts_test.dart	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/vmservice.status	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

6 years, 3 months ago (2014-09-04 18:38:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 39882 (presubmit successful).