Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 54473003: Fix a bug in the way we deal with HTypeKnown instructions in our SSA type propagation phase. (Closed)

Created:
7 years, 1 month ago by ngeoffray
Modified:
7 years, 1 month ago
Reviewers:
lukas, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a bug in the way we deal with HTypeKnown instructions in our SSA type propagation phase. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29664

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart View 1 chunk +19 lines, -18 lines 0 comments Download
A tests/language/type_propagation3_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 1 month ago (2013-10-31 10:41:10 UTC) #1
kasperl
LGTM.
7 years, 1 month ago (2013-10-31 11:35:50 UTC) #2
ngeoffray
7 years, 1 month ago (2013-10-31 11:40:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698