Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 54473002: Add types to annotation constants. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Add types to annotation constants. A user had the problem that "proxy" had priority over his instance field, which is ok, but that he didn't get a warning because our "proxy" was dynamic. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/core/annotations.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 10:13:13 UTC) #1
Anders Johnsen
lgtm
7 years, 1 month ago (2013-10-31 10:16:19 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-10-31 10:18:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698