Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 544693002: Split channels library. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -991 lines) Patch
M pkg/analysis_server/lib/http_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_manager.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/channel.dart View 1 chunk +0 lines, -386 lines 0 comments Download
A pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 chunk +137 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/channel/channel.dart View 1 chunk +151 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 1 chunk +122 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/stdio_server.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 9 chunks +55 lines, -198 lines 0 comments Download
A + pkg/analysis_server/test/channel/test_all.dart View 2 chunks +5 lines, -5 lines 0 comments Download
A pkg/analysis_server/test/channel/web_socket_channel_test.dart View 1 chunk +159 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/channel_test.dart View 1 chunk +0 lines, -395 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-04 16:01:05 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-04 16:40:34 UTC) #2
scheglov
6 years, 3 months ago (2014-09-04 17:54:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39881 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698