Issue 54463004: Fix issue 14659: intrinsic method must check if the start, end arguments are Smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54463004: Fix issue 14659: intrinsic method must check if the start, end arguments are Smi. (Closed)

Created:
7 years, 1 month ago by srdjan

Modified:
7 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix issue 14659: intrinsic method must check if the start, end arguments are Smi. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29686

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -4 lines)			Patch
M	runtime/vm/intrinsifier_arm.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
A	tests/language/substring_test.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

srdjan

7 years, 1 month ago (2013-10-31 18:16:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29686 (presubmit successful).