Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 544273003: Initial support for execution domain (Closed)

Created:
6 years, 3 months ago by Brian Wilkerson
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initial support for execution domain R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=39974

Patch Set 1 #

Patch Set 2 : Fixed formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -38 lines) Patch
M pkg/analysis_server/doc/api.html View 3 chunks +10 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 8 chunks +62 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +13 lines, -1 line 0 comments Download
A pkg/analysis_server/lib/src/domain_execution.dart View 1 1 chunk +210 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/domain_execution_test.dart View 1 1 chunk +274 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 3 months ago (2014-09-07 17:15:58 UTC) #2
Paul Berry
lgtm
6 years, 3 months ago (2014-09-08 16:04:39 UTC) #3
Brian Wilkerson
6 years, 3 months ago (2014-09-08 16:21:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 39974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698