Issue 543713002: Reduce the number of Uris parsed in builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543713002: Reduce the number of Uris parsed in builtin. (Closed)

Created:
6 years, 3 months ago by Anders Johnsen

Modified:
6 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce the number of Uris parsed in builtin. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39896

Patch Set 2 : Fix comment #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -16 lines)			Patch
	M	runtime/bin/builtin.dart	View	1	2 chunks	+26 lines, -12 lines	0 comments	Download
	M	runtime/bin/dartutils.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

LGTM -Ivan https://codereview.chromium.org/543713002/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/543713002/diff/1/runtime/bin/builtin.dart#newcode283 runtime/bin/builtin.dart:283: // Create a Uri of 'userUri'. Is ...

6 years, 3 months ago (2014-09-04 15:33:18 UTC) #3

Anders Johnsen

Committed patchset #2 (id:20001) manually as 39896 (presubmit successful).

6 years, 3 months ago (2014-09-05 05:33:24 UTC) #4

Anders Johnsen

6 years, 3 months ago (2014-09-05 05:33:25 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/543713002/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/543713002/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:283: // Create a Uri of 'userUri'. Is the input uri is
a package uri, the package uri
On 2014/09/04 15:33:18, Ivan Posva wrote:
> If the input uri ..., then the package ...

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 543713002: Reduce the number of Uris parsed in builtin. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix comment #

Messages