Bubble up exceptions throw async/await.

Bubble up exceptions throw async/await.

This CL addresses bubbling up exceptions through async and await. It adds another parameter to the continuation that can be used to rethrow an error.

BUG=
R=hausner@google.com, srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39926

[Michael Lippautz (Google), 2014-09-05 16:38:57]

mlippautz@google.com changed reviewers:
+ hausner@google.com, srdjan@google.com

[Michael Lippautz (Google), 2014-09-05 16:38:58]

PTAL

Maybe somebody has to take over this. 

The work around through calling a function in a patch file is necessary to avoid
parsing/compiling troubles with anonymous closures.

[hausner, 2014-09-05 17:52:27]

Do the tests run with this CL applied?

Is there anything missing or does the code just need polishing in your opinion?

https://codereview.chromium.org/542893004/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/542893004/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:3008: // Async closures have one optional parameter for
continuation results.
This comment is no longer correct I think.

[Michael Lippautz (Google), 2014-09-05 18:03:30]

On 2014/09/05 17:52:27, hausner wrote:
> Do the tests run with this CL applied?
> 

Yes. I am currently compiling some more tests that check for bubbling up
exceptions.

> Is there anything missing or does the code just need polishing in your
opinion?
> 

There's nothing missing and it probably needs polishing (?) I don't see a better
way to wrap the body of an async closure into a try/catch though. (Given the
current parser API)

https://codereview.chromium.org/542893004/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/542893004/diff/1/runtime/vm/parser.cc#newcode...
runtime/vm/parser.cc:3008: // Async closures have one optional parameter for
continuation results.
On 2014/09/05 17:52:26, hausner wrote:
> This comment is no longer correct I think.

Done.

[hausner, 2014-09-05 19:10:53]

LGTM.

[srdjan, 2014-09-05 19:32:11]

lgtm

https://codereview.chromium.org/542893004/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/542893004/diff/40001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9: #include "vm/ast_printer.h"
Remove?

https://codereview.chromium.org/542893004/diff/40001/tests/language/await_exc...
File tests/language/await_exceptions_test.dart (right):

https://codereview.chromium.org/542893004/diff/40001/tests/language/await_exc...
tests/language/await_exceptions_test.dart:67: print(x);
Why printing in test?

[Michael Lippautz (Google), 2014-09-05 19:50:19]

Thanks!

https://codereview.chromium.org/542893004/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/542893004/diff/40001/runtime/vm/parser.cc#new...
runtime/vm/parser.cc:9: #include "vm/ast_printer.h"
On 2014/09/05 19:32:10, srdjan wrote:
> Remove?

Done.

https://codereview.chromium.org/542893004/diff/40001/tests/language/await_exc...
File tests/language/await_exceptions_test.dart (right):

https://codereview.chromium.org/542893004/diff/40001/tests/language/await_exc...
tests/language/await_exceptions_test.dart:67: print(x);
On 2014/09/05 19:32:10, srdjan wrote:
> Why printing in test?

Left over. removed.

[Michael Lippautz (Google), 2014-09-05 19:50:45]

Committed patchset #4 (id:60001) manually as 39926 (presubmit successful).