Delete stale compiled files.

Delete stale compiled files.

BUG=https://code.google.com/p/dart/issues/detail?id=20873
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40134

[Bob Nystrom, 2014-09-10 20:29:39]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2014-09-10 21:08:18]

lgtm

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:98: var sources = new
Set<String>();
Nit: I wouldn't type this.

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:121: if (p.extension(entry.path) !=
".dart") continue;
If there are specific non-Dart files we don't want to delete (e.g. the README) I
think we should list them explicitly.

[Bob Nystrom, 2014-09-10 22:42:34]

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
File sdk/lib/_internal/pub/bin/async_compile.dart (right):

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:98: var sources = new
Set<String>();
On 2014/09/10 21:08:18, nweiz wrote:
> Nit: I wouldn't type this.

Done.

https://codereview.chromium.org/542193005/diff/1/sdk/lib/_internal/pub/bin/as...
sdk/lib/_internal/pub/bin/async_compile.dart:121: if (p.extension(entry.path) !=
".dart") continue;
On 2014/09/10 21:08:18, nweiz wrote:
> If there are specific non-Dart files we don't want to delete (e.g. the README)
I
> think we should list them explicitly.

I think it's better to whitelist this. The compiler only generates .dart files
(and the README, but that's special) so it shouldn't delete random other files
like .DS_Store, etc. I only want it to clean up its own mess.

[Bob Nystrom, 2014-09-11 00:33:33]

Committed patchset #2 (id:20001) manually as 40134 (presubmit successful).