Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 541683002: Generate needed classes for constant maps in metadata. (Closed)

Created:
6 years, 3 months ago by Johnni Winther
Modified:
6 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate needed classes for constant maps in metadata. BUG=http://dartbug.com/20776 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=39860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/registry.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + tests/lib/mirrors/metadata_const_map_test.dart View 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
6 years, 3 months ago (2014-09-04 11:21:05 UTC) #2
floitsch
LGTM.
6 years, 3 months ago (2014-09-04 11:28:08 UTC) #3
Johnni Winther
6 years, 3 months ago (2014-09-04 11:49:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 39860 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698