test.dart: Serve the browser test driver page from the test file HTTP server.

test.dart: Serve the browser test driver page from the test file HTTP server.

BUG=
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39907

[Bill Hesse, 2014-09-04 14:25:16]

whesse@google.com changed reviewers:
+ ricow@chromium.org

[Bill Hesse, 2014-09-04 14:25:17]

The test-driver-port option to test.dart will be removed in a later CL, once the
buildbots stop setting it.

[ricow1, 2014-09-05 06:45:10]

ricow@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2014-09-05 06:45:11]

LGTM, but this is moving us even further down the path of having a hard coupling
of the test scripts and the browser controllers. I think we should try to keep
the api surface between the two very limited, and not rely on configuration map
to pass in parameters (why do the browser controller need to know about
configuration?). We can easily create a typed configuration object that we pass
in to the browser controller from the testing scripts.

https://codereview.chromium.org/540933002/diff/1/tools/testing/dart/browser_c...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/540933002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:814: final Map configuration;
Please file a bug to remove this

https://codereview.chromium.org/540933002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:850: checkedMode =
configuration['checked'];
indentation

https://codereview.chromium.org/540933002/diff/1/tools/testing/dart/browser_c...
tools/testing/dart/browser_controller.dart:1299: DispatchingServer server =
configuration['_servers_'].server;
I think that we should allow for this to not be passed in. If it is not,
instantiate it here

[Bill Hesse, 2014-09-05 11:01:33]

Committed patchset #2 (id:20001) manually as 39907 (presubmit successful).