Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 540303002: Fix xcode build for real. (Closed)

Created:
6 years, 3 months ago by Florian Schneider
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 2 1 chunk +12 lines, -7 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
6 years, 3 months ago (2014-09-05 11:11:10 UTC) #2
Vyacheslav Egorov (Google)
https://codereview.chromium.org/540303002/diff/1/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/540303002/diff/1/runtime/vm/flow_graph_compiler.cc#newcode1359 runtime/vm/flow_graph_compiler.cc:1359: uword blocked_mask = ((blocked > kNoRegister) ? 1 << ...
6 years, 3 months ago (2014-09-05 11:18:50 UTC) #3
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/540303002/diff/40001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://codereview.chromium.org/540303002/diff/40001/runtime/vm/flow_graph_compiler.cc#newcode1355 runtime/vm/flow_graph_compiler.cc:1355: return reg != kNoRegister ? 1 << reg ...
6 years, 3 months ago (2014-09-05 11:29:45 UTC) #4
Florian Schneider
6 years, 3 months ago (2014-09-05 11:30:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r39909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698