Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 53993004: Change integer canonicalization to use CheckAndCanonicalize (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Change integer canonicalization to use CheckAndCanonicalize R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M runtime/lib/integers.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-11-01 08:52:18 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-11-01 08:58:50 UTC) #2
Lasse Reichstein Nielsen
7 years, 1 month ago (2013-11-01 09:42:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698