Reuse HttpClient in the built-in resource loader.

Reuse HttpClient in the built-in resource loader.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39848

[Anders Johnsen, 2014-09-03 12:08:59]

ajohnsen@google.com changed reviewers:
+ iposva@google.com

[Anders Johnsen, 2014-09-03 12:08:59]

My dart2js benchmark goes from ~520ms to ~470ms.

[Ivan Posva, 2014-09-03 15:37:38]

LGTMwC

-Ivan

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:217: // Only create a ByteBuilder if multiple chunks
are received.
I am reading this comment as a TODO, correct?

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:259: if (_httpClient != null) {
Can you move this code in a helper function which closes the client and signals
the VM? Because otherwise we forget to call it in other places where we are
"done loading". Like below in the error case.

[Anders Johnsen, 2014-09-04 06:53:48]

Committed patchset #3 (id:40001) manually as 39848 (presubmit successful).

[Anders Johnsen, 2014-09-04 08:26:29]

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:217: // Only create a ByteBuilder if multiple chunks
are received.
On 2014/09/03 15:37:38, Ivan Posva wrote:
> I am reading this comment as a TODO, correct?

Removing, the bytebuffer does this for us.

https://codereview.chromium.org/539473002/diff/40001/runtime/bin/builtin.dart...
runtime/bin/builtin.dart:259: if (_httpClient != null) {
On 2014/09/03 15:37:38, Ivan Posva wrote:
> Can you move this code in a helper function which closes the client and
signals
> the VM? Because otherwise we forget to call it in other places where we are
> "done loading". Like below in the error case.

Good catch.