Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 539353002: Use RefactoringFeedback objects in Java. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, ricow1, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -122 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/GetRefactoringConsumer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableFeedback.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodFeedback.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringFeedback.java View 1 chunk +0 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RenameFeedback.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 3 chunks +9 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/processor/GetRefactoringProcessor.java View 3 chunks +21 lines, -59 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 19 chunks +41 lines, -43 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 3 months ago (2014-09-04 21:42:39 UTC) #1
jwren
On 2014/09/04 21:42:39, scheglov wrote: LGTM
6 years, 3 months ago (2014-09-04 22:19:06 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-04 22:40:11 UTC) #3
scheglov
6 years, 3 months ago (2014-09-04 23:29:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39889 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698