Issue 539113002: Update the configuration file googleapis generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539113002: Update the configuration file googleapis generation (Closed)

Created:
6 years, 3 months ago by Søren Gjesse

Modified:
6 years, 2 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, kevmoo

Base URL:
git@github.com:dart-lang/googleapis.git@master

Visibility:
Public.

More Reviews

Description

Update the configuration file googleapis generation Looked through all APIs and added all non-beta APIs to google the googleapis package. Added all beta APIs to the googleapis_beta package. Added a comment URL for looking up the API web page (hopefuly they will not become stale). Removed the Dart code and added an initial README with instructions to get started. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/gcloud/commit/5c0b55a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -442 lines)			Patch
M	README.md	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	config.yaml	View		2 chunks	+96 lines, -96 lines	0 comments	Download
D	main.dart	View		1 chunk	+0 lines, -262 lines	0 comments	Download
D	pubspec.lock	View		1 chunk	+0 lines, -75 lines	0 comments	Download
D	pubspec.yaml	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

I could not find reasonable criteria for not including all public APIs.

6 years, 3 months ago (2014-09-04 13:29:01 UTC) #1

kustermann

LGTM https://codereview.chromium.org/539113002/diff/1/README.md File README.md (right): https://codereview.chromium.org/539113002/diff/1/README.md#newcode19 README.md:19: - Update config.yaml with new version and generate ...

6 years, 3 months ago (2014-09-04 13:54:36 UTC) #2

Søren Gjesse

Committed patchset #2 manually as 5c0b55a (presubmit successful).

6 years, 3 months ago (2014-09-04 14:01:38 UTC) #3

Søren Gjesse

6 years, 2 months ago (2014-09-29 16:11:41 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/539113002/diff/1/README.md
File README.md (right):

https://codereview.chromium.org/539113002/diff/1/README.md#newcode19
README.md:19: - Update config.yaml with new version and generate again
On 2014/09/04 13:54:36, kustermann wrote:
> Can long lines be broken in markdown? If so, break them.

They can. Done.

Expand Messages | Collapse Messages