Ensure constructorName symbols include private manglings.

Ensure constructorName symbols include private manglings.

R=asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30178

[rmacnak, 2013-10-31 01:15:57]

Fixes a regression for C1.

Technically this introduces a bug where the names of two anonymous mixin
applications with the same qualified name defined in two separate libraries will
have equal symbols when they should be different.

Unfortunately, unmangling symbols lib.S@xxx with lib.X.Y@xx id problematic. 
Needs more thought.

[ahe, 2013-10-31 10:49:07]

https://codereview.chromium.org/53883002/diff/1/tests/lib/mirrors/constructor...
File tests/lib/mirrors/constructor_private_name_test.dart (right):

https://codereview.chromium.org/53883002/diff/1/tests/lib/mirrors/constructor...
tests/lib/mirrors/constructor_private_name_test.dart:25:
fooMirror.newInstance(constructorName, []);
Could you extend these tests to ensure that you don't find private symbols in a
different library.

[rmacnak, 2013-10-31 18:45:03]

+Siva, Gilad

Moved unmangling from C++ code to Dart code.
Handle the mixin application situation mentioned above.
Added test for the same.
Added test for attempting invocation with private symbols for the wrong library.

[gbracha, 2013-10-31 19:02:17]

Test lgtm.

https://codereview.chromium.org/53883002/diff/150001/tests/lib/mirrors/constr...
File tests/lib/mirrors/constructor_private_name_test.dart (right):

https://codereview.chromium.org/53883002/diff/150001/tests/lib/mirrors/constr...
tests/lib/mirrors/constructor_private_name_test.dart:29:
(_fooMirror.declarations[#_Foo._private] as MethodMirror).constructorName;
So constructor names include the class name? If it doesn't change very soon, it
never will.

[rmacnak, 2013-10-31 21:06:39]

https://codereview.chromium.org/53883002/diff/150001/tests/lib/mirrors/constr...
File tests/lib/mirrors/constructor_private_name_test.dart (right):

https://codereview.chromium.org/53883002/diff/150001/tests/lib/mirrors/constr...
tests/lib/mirrors/constructor_private_name_test.dart:29:
(_fooMirror.declarations[#_Foo._private] as MethodMirror).constructorName;
On 2013/10/31 19:02:17, gbracha wrote:
> So constructor names include the class name? If it doesn't change very soon,
it
> never will.

A constructor's simpleName includes the class name (key in member maps).
A constructor's constructorName does not (input to newInstance).
It's too late to change this :/

[siva, 2013-11-10 05:32:25]

lgtm

https://codereview.chromium.org/53883002/diff/230001/runtime/lib/mirrors_patc...
File runtime/lib/mirrors_patch.dart (right):

https://codereview.chromium.org/53883002/diff/230001/runtime/lib/mirrors_patc...
runtime/lib/mirrors_patch.dart:72: }
Might be more readable if you named the bool skip and inverted the condition
here.

[rmacnak, 2013-11-11 23:08:48]

Committed patchset #7 manually as r30178 (presubmit successful).