Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 538803002: Enable await in for and for-in loops. (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)
Modified:
6 years, 3 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable await in for and for-in loops. BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39880

Patch Set 1 #

Total comments: 4

Patch Set 2 : adressed comments #

Patch Set 3 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -14 lines) Patch
M runtime/vm/ast.h View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/parser.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 8 chunks +41 lines, -12 lines 0 comments Download
M tests/language/await_future_test.dart View 1 2 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Lippautz (Google)
PTAL
6 years, 3 months ago (2014-09-03 23:23:33 UTC) #2
hausner
LGTMwC https://codereview.chromium.org/538803002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/538803002/diff/1/runtime/vm/parser.cc#newcode6070 runtime/vm/parser.cc:6070: if (preamble != NULL) { I don't understand ...
6 years, 3 months ago (2014-09-04 16:30:58 UTC) #3
Michael Lippautz (Google)
https://codereview.chromium.org/538803002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/538803002/diff/1/runtime/vm/parser.cc#newcode6070 runtime/vm/parser.cc:6070: if (preamble != NULL) { On 2014/09/04 16:30:58, hausner ...
6 years, 3 months ago (2014-09-04 17:07:38 UTC) #4
srdjan
lgtm
6 years, 3 months ago (2014-09-04 17:32:45 UTC) #5
Michael Lippautz (Google)
6 years, 3 months ago (2014-09-04 17:42:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 39880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698