Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 538703002: Enable await in while and do-while. (Closed)

Created:
6 years, 3 months ago by Michael Lippautz (Google)
Modified:
6 years, 3 months ago
Reviewers:
srdjan, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable await in while and do-while. BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39839

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -39 lines) Patch
M runtime/vm/ast.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 5 chunks +25 lines, -11 lines 0 comments Download
M runtime/vm/parser.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 2 10 chunks +32 lines, -12 lines 0 comments Download
M tests/language/await_future_test.dart View 1 chunk +53 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Lippautz (Google)
PTAL
6 years, 3 months ago (2014-09-03 21:00:38 UTC) #2
srdjan
lgtm
6 years, 3 months ago (2014-09-03 21:22:58 UTC) #3
hausner
LGTMwC https://codereview.chromium.org/538703002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/538703002/diff/1/runtime/vm/parser.cc#newcode6980 runtime/vm/parser.cc:6980: while_node->set_condition_preamble(await_preamble); Would it make sense to add the ...
6 years, 3 months ago (2014-09-03 21:37:57 UTC) #4
Michael Lippautz (Google)
https://codereview.chromium.org/538703002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/538703002/diff/1/runtime/vm/parser.cc#newcode6980 runtime/vm/parser.cc:6980: while_node->set_condition_preamble(await_preamble); On 2014/09/03 21:37:57, hausner wrote: > Would it ...
6 years, 3 months ago (2014-09-03 21:49:43 UTC) #5
Michael Lippautz (Google)
6 years, 3 months ago (2014-09-03 21:51:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 39839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698