Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 538373002: Don't do Uri->String->Uri when resolving package imports. (Closed)

Created:
6 years, 3 months ago by Anders Johnsen
Modified:
6 years, 3 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't do Uri->String->Uri when resolving package imports. This fixes an issue on windows where Uri.parse(Uri.toFilePath()) would produce escaped Windows paths. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=39898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/bin/builtin.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Anders Johnsen
6 years, 3 months ago (2014-09-05 06:20:26 UTC) #2
ricow1
lgtm
6 years, 3 months ago (2014-09-05 06:23:55 UTC) #3
Anders Johnsen
6 years, 3 months ago (2014-09-05 06:24:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698